Skip to content

gh-132143: Fix the AssertionError in the test case test.test_sys.TestRemoteExec #132248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

littlebutt
Copy link
Contributor

gh-132143: Fix the AssertionError in the test case test.test_sys.TestRemoteExec

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Apr 7, 2025
@ZeroIntensity ZeroIntensity added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 8, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 5e4c2a7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132248%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 8, 2025
@chris-eibl chris-eibl requested a review from pablogsal April 10, 2025 05:40
@chris-eibl chris-eibl added the 3.14 bugs and security fixes label Apr 11, 2025
@aisk
Copy link
Contributor

aisk commented May 5, 2025

This can't be tested on GHA because it uses the English locale and the error cannot be reproduced. On my Windows machine with the Simplified Chinese locale, I can verify that the issue exists and that this PR fixes it, so I approve it.

@pablogsal pablogsal merged commit d6078ed into python:main May 5, 2025
48 checks passed
@pablogsal
Copy link
Member

Thanks a lot for your contribution @littlebutt

@pablogsal
Copy link
Member

Thanks for the review @aisk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.14 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants