gh-99108: add support for SIMD-accelerated HMAC-BLAKE2 #132120
+75
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
picnixz
commented
Apr 5, 2025
•
picnixz
commented
- Issue: Replace built-in hashlib with verified implementations from HACL* #99108
picnixz
added
skip news
🔨 test-with-buildbots
This comment was marked as resolved.
This comment was marked as resolved.
bedevere-bot
removed
the
🔨 test-with-buildbots
This comment was marked as resolved.
This comment was marked as resolved.
picnixz
added
the
🔨 test-with-buildbots
This comment was marked as resolved.
This comment was marked as resolved.
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Some build bots seem to be stuck, but I'll sleep and then see if I need to rerun them. |
AA-Turner
reviewed
Apr 6, 2025
| #else | ||
| // fmt: off |
There was a problem hiding this comment.
Remove these comments? We don't auto-format C code.
There was a problem hiding this comment.
That's for me. I do auto format my code. And as the maintainer of this module I would like to keep them as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.