gh-132106: Allow logging.handlers.QueueListener to be used as a context manager #132107
Conversation
| @@ -4347,6 +4347,18 @@ def test_queue_listener(self): | |||
| self.assertTrue(handler.matches(levelno=logging.CRITICAL, message='6')) | |||
| handler.close() | |||
|
|
|||
| @unittest.skipUnless(hasattr(logging.handlers, 'QueueListener'), | |||
There was a problem hiding this comment.
I'm surprised but when is QueueListener not available?
There was a problem hiding this comment.
Great question. No idea. I just matched the surrounding tests 😆
Co-authored-by: Brian Schubert <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
…e running (prevents a thread leak) Update docs
There was a problem hiding this comment.
I'd prefer if we can make the multi-start check in a separate PR so that it becomes much easier to revert commits if needs arise. You can re-use the same issue however. We would then merge this PR afterwards (I'll make it so that we don't hang too much on this PR)
|
@picnixz , I removed the listener already started stuff. I'll do a fresh PR after this one merges (since otherwise I'll merge conflict anyways with this one).. (Unless you'd like that one first instead?) |
| # you want to happen. | ||
| root.warning('Look out!') | ||
| listener.stop() | ||
| with QueueListener(que, handler) as listener: |
There was a problem hiding this comment.
Instead of this new usage replacing the older, I would like the old usage to be kept in the documentation, with the next paragraph showing the new usage close to the Python versionchanged which clearly shows that this way of doing things is restricted to particular Python versions.
📚 Documentation preview 📚: https://cpython-previews--132107.org.readthedocs.build/