Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-46236: Add missing PyUnicode_FromOrdinal() doc #132040

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Apr 3, 2025

@rruuaanng rruuaanng changed the title Add missing PyUnicode_FromOrdinal() doc gh-46236: Add missing PyUnicode_FromOrdinal() doc Apr 3, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 3, 2025
33 tasks
Comment on lines +603 to +604
The ordinal must be in ``range(0x110000)``. A :exc:`ValueError` is
raised in case it is not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The ordinal must be in ``range(0x110000)``. A :exc:`ValueError` is
raised in case it is not.
The ordinal must be in ``range(0x110000)``. A :exc:`ValueError` is
raised if it is not.

"in case" sounds a bit misleading here. I guess "in the case" would work if we want that wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants