-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-131524: Update platform CLI to use argparse #131542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And don't forget about a NEWS entry :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have help which shows the arguments:
❯ ./python.exe -m platform -h
usage: python.exe -m platform [-h] [--terse] [--nonaliased] [{nonaliased,terse} ...]
positional arguments:
{nonaliased,terse}
options:
-h, --help show this help message and exit
--terse
--nonaliased
But doesn't say what they do. Please can you add short descriptions?
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
The help message now gives a short description of each flag
|
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Maybe it's worth adding a |
This can be a followup PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@donBarbos GitHub says you requested changes, is there anything outstanding on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I thought I was only leaving comments
Closes: #131524
Related To: #131178
This PR updates the platform CLI to use argparse which adds
--help
flags and a usage section which was previously unavailable.platform
CLI #131524