-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-130130: Clarify hash=False
docs in dataclasses.field
#130324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hash=False
docs in dataclasses.field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait for @ericvsmith's review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@Sabfo congrats on your first PR! 🎉 |
Thanks @Sabfo for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Thanks @Sabfo for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…thonGH-130324) (cherry picked from commit 47ace53) Co-authored-by: Sabfo <[email protected]>
GH-130336 is a backport of this pull request to the 3.12 branch. |
…thonGH-130324) (cherry picked from commit 47ace53) Co-authored-by: Sabfo <[email protected]>
GH-130337 is a backport of this pull request to the 3.13 branch. |
We usually backport doc changes, unless this behavior is new. |
Clarify the meaning
dataclasses.field(..., hash=False)
📚 Documentation preview 📚: https://cpython-previews--130324.org.readthedocs.build/
dataclasses.field(..., hash=False)
#130130