Skip to content

Fix some ctypes docs typos #130307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Fix some ctypes docs typos #130307

merged 2 commits into from
Feb 20, 2025

Conversation

Alcaro
Copy link
Contributor

@Alcaro Alcaro commented Feb 19, 2025

Probably plenty of potential for improvement left (string representation and memory management on FFI boundaries are easy footguns, I'm not sure if they're treated with the appropriate respect), but I don't know how to do that.


📚 Documentation preview 📚: https://cpython-previews--130307.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Feb 19, 2025
@ghost
Copy link

ghost commented Feb 19, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@encukou encukou merged commit 417372b into python:main Feb 20, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks @Alcaro for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
(cherry picked from commit 417372b)

Co-authored-by: Alcaro <[email protected]>
@miss-islington-app
Copy link

Sorry, @Alcaro and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 417372bd43ecb61a848eadb3ce142f0ed3441b49 3.12

@bedevere-app
Copy link

bedevere-app bot commented Feb 20, 2025

GH-130343 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 20, 2025
@encukou
Copy link
Member

encukou commented Feb 20, 2025

I don't know how to do that.

You might try the Diátaxis way: pick a small change, and don't worry if it's the most important one.

@encukou
Copy link
Member

encukou commented Feb 20, 2025

I could not cleanly backport this to 3.12 due to a conflict.

The main reason we do backports is avoiding future conflicts; since there's one already I'm not planning to backport to 3.12.

@encukou encukou removed the needs backport to 3.12 only security fixes label Feb 20, 2025
@encukou encukou removed their assignment Feb 20, 2025
encukou pushed a commit that referenced this pull request Feb 20, 2025
Fix some ctypes docs typos (GH-130307)
(cherry picked from commit 417372b)

Co-authored-by: Alcaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants