-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-127260: Make more consistent to raising errors of fromisoformat
methods in both implementations
#130134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
Emphasize the change in strictness in the C implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another great PR @donBarbos!
Thank you for review |
My fixes for
fromisoformat
method:_pydatetime
implementation raise error if there are extra characters afterZ
like in_datetime
implementation (this was documented)_pydatetime
implementation also support:
as microsecond separator like in_datetime
implementation (I didn't find this in documentation)fromisoformat
methods indatetime
module implementations #127260