Skip to content

gh-127260: Make more consistent to raising errors of fromisoformat methods in both implementations #130134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

donBarbos
Copy link
Contributor

@donBarbos donBarbos commented Feb 14, 2025

My fixes for fromisoformat method:

  • _pydatetime implementation raise error if there are extra characters after Z like in _datetime implementation (this was documented)
  • _pydatetime implementation also support : as microsecond separator like in _datetime implementation (I didn't find this in documentation)
  • same first raised error (see related issue, example 3)
  • add tests to check that both implementations work the same way

@bedevere-app
Copy link

bedevere-app bot commented Feb 18, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@donBarbos
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Feb 18, 2025

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from pganssle February 18, 2025 13:59
Emphasize the change in strictness in the C implementation.
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another great PR @donBarbos!

@donBarbos
Copy link
Contributor Author

Thank you for review

@pganssle pganssle enabled auto-merge (squash) February 18, 2025 14:55
@pganssle pganssle merged commit 427dd10 into python:main Feb 18, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants