-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-126022: Replace TeX quotation marks with "
in Doc/license.rst
#129535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"
in Doc/license.rst
"
in Doc/license.rst"
in Doc/license.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, and does produce better rendered output -- it's unfortunate it was missed in #128516, though.
A
"
in Doc/license.rst"
in Doc/license.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look like:
And those OSI copies use regular quotes, so this PR looks fine.
... it's unfortunate it was missed in #128516, though.
These backticks are in the third-party licences:
https://docs.python.org/3/license.html#licenses-and-acknowledgements-for-incorporated-software
But those aren't listed in https://github.com/python/cpython/blob/main/LICENSE. Should they be?
I also wonder why Sphinx Lint found these in translators' .pot
files but not in Doc/license.rst
in our CI?
Sphinx Lint skips code blocks in .rst. In .pot files all entries are being linted. |
Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…e.rst (pythonGH-129535) (cherry picked from commit cf4c4ec) Co-authored-by: Stan Ulbrych <[email protected]>
GH-129551 is a backport of this pull request to the 3.13 branch. |
Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to
|
…se.rst (GH-129535) (#129551) Co-authored-by: Stan Ulbrych <[email protected]>
…/license.rst (pythonGH-129535) (cherry picked from commit cf4c4ec) Co-authored-by: Stan Ulbrych <[email protected]>
GH-129554 is a backport of this pull request to the 3.12 branch. |
…se.rst (GH-129535) (#129554) Co-authored-by: Stan Ulbrych <[email protected]>
These have been causing issues with sphinx-lint see here. These are also consistent with those used in the python and OSI license.
📚 Documentation preview 📚: https://cpython-previews--129535.org.readthedocs.build/