Skip to content

gh-126022: Replace TeX quotation marks with " in Doc/license.rst #129535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Jan 31, 2025

These have been causing issues with sphinx-lint see here. These are also consistent with those used in the python and OSI license.


📚 Documentation preview 📚: https://cpython-previews--129535.org.readthedocs.build/

@AA-Turner AA-Turner changed the title gh-126022: Use more common and less problematic quotes gh-126022: Replace LaTeX quotes with " in Doc/license.rst Feb 1, 2025
@AA-Turner AA-Turner changed the title gh-126022: Replace LaTeX quotes with " in Doc/license.rst gh-126022: Replace LaTeX quotation marks with " in Doc/license.rst Feb 1, 2025
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, and does produce better rendered output -- it's unfortunate it was missed in #128516, though.

A

@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 1, 2025
@AA-Turner AA-Turner changed the title gh-126022: Replace LaTeX quotation marks with " in Doc/license.rst gh-126022: Replace TeX quotation marks with " in Doc/license.rst Feb 1, 2025
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like:

And those OSI copies use regular quotes, so this PR looks fine.

... it's unfortunate it was missed in #128516, though.

These backticks are in the third-party licences:

https://docs.python.org/3/license.html#licenses-and-acknowledgements-for-incorporated-software

But those aren't listed in https://github.com/python/cpython/blob/main/LICENSE. Should they be?

I also wonder why Sphinx Lint found these in translators' .pot files but not in Doc/license.rst in our CI?

@m-aciek
Copy link
Contributor

m-aciek commented Feb 1, 2025

I also wonder why Sphinx Lint found these in translators' .pot files but not in Doc/license.rst in our CI?

Sphinx Lint skips code blocks in .rst. In .pot files all entries are being linted.

@hugovk hugovk merged commit cf4c4ec into python:main Feb 1, 2025
32 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 1, 2025
…e.rst (pythonGH-129535)

(cherry picked from commit cf4c4ec)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 1, 2025

GH-129551 is a backport of this pull request to the 3.13 branch.

@miss-islington-app
Copy link

Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cf4c4ecc26c7e3b89f2e56893260a8a3319dab3d 3.12

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 1, 2025
@StanFromIreland StanFromIreland deleted the fix-quotes branch February 1, 2025 16:56
hugovk pushed a commit that referenced this pull request Feb 1, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request Feb 1, 2025
…/license.rst (pythonGH-129535)

(cherry picked from commit cf4c4ec)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 1, 2025

GH-129554 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 1, 2025
hugovk added a commit that referenced this pull request Feb 1, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants