gh-129405: Fix doc for Py_mod_multiple_interpreters default, and add test #129406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
requested review from
ericsnowcurrently,
brettcannon,
ncoghlan and
warsaw
as code owners
encukou
added
skip news
needs backport to 3.12
|
I'll merge next week if there are no objections & the tests pass. |
encukou
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 74ffd46 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F30617%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 24, 2025
…d add test (pythonGH-129406) (cherry picked from commit fc8d2cb) Co-authored-by: Petr Viktorin <[email protected]>
|
Sorry, @encukou, I could not cleanly backport this to |
|
GH-130507 is a backport of this pull request to the 3.13 branch. |
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Feb 24, 2025
|
GH-130510 is a backport of this pull request to the 3.12 branch. |
encukou
added a commit
that referenced
this pull request
Feb 24, 2025
…nd add test (GH-129406) (GH-130507) (cherry picked from commit fc8d2cb) Co-authored-by: Petr Viktorin <[email protected]>
encukou
added a commit
that referenced
this pull request
Feb 27, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the docs, and runs the test for the default value also for a module without the slot.
@ericsnowcurrently, does this look OK?
Py_mod_multiple_interpretersdefault is incorrect #129405📚 Documentation preview 📚: https://cpython-previews--129406.org.readthedocs.build/