Skip to content

gh-129370: Update libregrtest to use f-strings #129371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MarcinKonowalczyk
Copy link

@MarcinKonowalczyk MarcinKonowalczyk commented Jan 27, 2025

Found and fixed all instances with ruff (And did read through them as opposed to just submitting a PR with a tool result! 😉):

ruff check --select UP031,UP032 --fix --unsafe-fixes ./Lib/test/libregrtest/

I've omitted the changes to Regtest::run_tests_sequentially as to not conflict with #129363.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

@bedevere-app
Copy link

bedevere-app bot commented Jan 27, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ZeroIntensity
Copy link
Member

Per @encukou closing the issue, we don't like to accept cosmetic changes like this. Sorry :(

@MarcinKonowalczyk
Copy link
Author

@ZeroIntensity ok 👍 good to know. sorry for the noise

@ZeroIntensity
Copy link
Member

It does hurt on our end to close PRs that had effort go into them, so hopefully this isn't discouraging! If you're interested in contributing, you might want to take a look at the devguide, which will help guide you through making PRs that get accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants