gh-126332: Add tests for _pyrepl.utils #129325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eendebakpt
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
AlexWaygood
changed the title
vstinner
reviewed
Feb 20, 2025
Lib/test/test_pyrepl/test_utils.py
Outdated
|
|
||
| self.assertEqual(wlen('hello'), 5) | ||
| self.assertEqual(wlen('hello'+'\x1a'), 7) | ||
| self.assertEqual(wlen('hello'+'\0x1B'), 9) |
There was a problem hiding this comment.
This test is strange. Are you testing the nul byte and then the string x1B on purpose?
There was a problem hiding this comment.
Good catch. I tried to create a special unicode character to hit one of the paths in wlen, but think I made a typo. I removed this test and added two others.
|
The Docs CI job fails, I'm not sure why. So I updated the branch to try to fix the issue. |
|
Thanks @eendebakpt for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 21, 2025
(cherry picked from commit 0c4248f) Co-authored-by: Pieter Eendebak <[email protected]>
|
GH-130414 is a backport of this pull request to the 3.13 branch. |
vstinner
pushed a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for methods
'wlenandstr_widthfrom_pyrepl.utils.