-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
GH-127178: convert _sysconfigdata to a JSON file #127180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
The change seems useful indeed. Is this PR closed by accident @FFY00, or for some other reason? |
Thanks for the context! |
Is there anything still outstanding which would prevent us from making the JSON file the single source of truth? Distributing the same information in two different formats will inevitably lead to confusion. From the perspective of cross-compiling packages for mobile, if the JSON file isn't going to be used, then I'd prefer if it wasn't there at all. |
It's an implementation detail, so you could remove it if desired. The installed JSON file is just a reference output of
|
The problem is, if external build systems do start using it (which they probably will once they notice it, whether we encourage them to or not), then removing it will no longer be an option. So any tool which needs to alter this data (as we're doing for Android and iOS in cibuildwheel), will have no choice but to alter it in both files. |
I guess I'm just not clear about what the purpose of this file is. You say it's "meant to help ... build systems during cross compilation", but the general principle is that anything starting with an underscore should not be used externally at all. |
_sysconfigdata
to a JSON file #127178