gh-114940: Add a Per-Interpreter Lock For the List of Thread States #127037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1757
to
+1761
| HEAD_LOCK(runtime); | ||
| if (runtime->stoptheworld.requested) { | ||
| decrement_stoptheworld_countdown(&runtime->stoptheworld); | ||
| } | ||
| HEAD_UNLOCK(runtime); |
There was a problem hiding this comment.
I think this is correct, but need to double-check.
|
It seems that there is an error in CI, I will refer to your implementation. |
rruuaanng
reviewed
Nov 20, 2024
There was a problem hiding this comment.
If I remember correctly, this was an issue that could not be changed because it would cause unexpected issues with CI (it was originally changed in my PR)
|
I have factored out gh-127077 and will later update this PR on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new lock may be used instead of the global "HEAD" lock. That global lock guards the list of interpreters, but unfortunately also gets used as a generic "lock everything". This change helps us move away from that situation.
FYI, this is very similar to gh-125561.