GH-126748: amend configure.rst description for the 'build_wasm' make target #126687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has nothing to do with `--with-emscripten-target` but rather is selected when the host is either wasm32-wasi or wasm32-emscripten.
bedevere-app
bot
added
docs
|
Can I get a skip-issue for this? |
|
As an aside, looking at the code here it seems that pgo will work on these platforms. Maybe we should raise an explicit error if |
erlend-aasland
changed the title
Yes, docs amendments like this do not need news entries. |
Let's follow this up in a dedicated issue. |
erlend-aasland
approved these changes
Nov 11, 2024
Opened: #126748 |
brettcannon
changed the title
|
Okay I updated the wording. |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
… make target (python#126687) Clarified the documentation around how the build_wasm target is selected.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
… make target (python#126687) Clarified the documentation around how the build_wasm target is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has nothing to do with
--with-emscripten-targetbut rather is selected when the host is either wasm32-wasi or wasm32-emscripten.cc @brettcannon @freakboy3742
@brettcannon this is another spot where wasi and emscripten are mixed together. We could consider splitting
build_wasmintobuild_emscriptenandbuild_wasiif it seems like a problem.📚 Documentation preview 📚: https://cpython-previews--126687.org.readthedocs.build/