gh-126489: Do not call persistent_id() for a persistent id in Python pickle #126490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Nov 6, 2024
•
serhiy-storchaka
commented
- Issue: Python implementation of pickle calls persistent_id() for a persistent id #126489
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 6, 2024
…ython pickle (pythonGH-126490) (cherry picked from commit 8fa4dc4) Co-authored-by: Serhiy Storchaka <[email protected]>
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-126514 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Nov 6, 2024
…id in Python pickle (pythonGH-126490) (cherry picked from commit 8fa4dc4) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-126516 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Nov 6, 2024
…Python pickle (GH-126490) (GH-126514) (cherry picked from commit 8fa4dc4) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Nov 6, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.