-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-126091: Always link generator frames when propagating a thrown-in exception through a yield-from chain #126092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrough a yield-from chain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a NEWS entry, this looks like a user-facing problem (though rare).
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
@ZeroIntensity alright, done. |
Co-authored-by: Peter Bierma <[email protected]>
…owerfb into genthrowstack
Okay the XXX comment is now back. |
DinoV
approved these changes
Nov 21, 2024
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Nov 23, 2024
…hrough a yield-from chain Summary: "Back port" of python/cpython#126092 Reviewed By: alexmalyshev Differential Revision: D66332155 fbshipit-source-id: 391f332af6dd58a5cd2deac30b8d87f3a762c399
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…wn-in exception through a yield-from chain (python#126092) Always link generator frames when propagating a thrown-in exception through a yield-from chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #126091.