Skip to content

gh-126091: Always link generator frames when propagating a thrown-in exception through a yield-from chain #126092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

jbower-fb
Copy link
Contributor

@jbower-fb jbower-fb commented Oct 28, 2024

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a NEWS entry, this looks like a user-facing problem (though rare).

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@jbower-fb
Copy link
Contributor Author

@ZeroIntensity alright, done.

@jbower-fb
Copy link
Contributor Author

Okay the XXX comment is now back.

@ZeroIntensity ZeroIntensity self-requested a review November 19, 2024 14:01
@DinoV DinoV merged commit e8bb053 into python:main Nov 21, 2024
43 checks passed
facebook-github-bot pushed a commit to facebookincubator/cinder that referenced this pull request Nov 23, 2024
…hrough a yield-from chain

Summary: "Back port" of python/cpython#126092

Reviewed By: alexmalyshev

Differential Revision: D66332155

fbshipit-source-id: 391f332af6dd58a5cd2deac30b8d87f3a762c399
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…wn-in exception through a yield-from chain (python#126092)

Always link generator frames when propagating a thrown-in exception through a yield-from chain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants