Skip to content

gh-120485: Add an override of allow_reuse_port on classes inheriting socketserver.TCPServer #120488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2024
Merged

gh-120485: Add an override of allow_reuse_port on classes inheriting socketserver.TCPServer #120488

merged 6 commits into from
Jun 16, 2024

Conversation

idankap
Copy link
Contributor

@idankap idankap commented Jun 14, 2024 •
edited by bedevere-app bot
Loading

@idankap idankap requested a review from vsajip as a code owner June 14, 2024 07:42
@ghost
Copy link

ghost commented Jun 14, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jun 14, 2024
Closed
@bedevere-app
Copy link

bedevere-app bot commented Jun 14, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@idankap idankap changed the title gh-120485: Add an override to allow_reuse_port on classes inheriting socketserver.TCPServer gh-120485: Add an override of allow_reuse_port on classes inheriting socketserver.TCPServer Jun 14, 2024
@vsajip vsajip added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 15, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vsajip for commit b278a0b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 15, 2024
vsajip
vsajip approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some buildbot failures but all appear unconnected to this change.

@vsajip vsajip merged commit 192d17c into python:main Jun 16, 2024
35 checks passed
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@idankap @vsajip @mrahtz
pythongh-120485: Add an override of allow_reuse_port on classes sub…
a5c986a 
…classing `socketserver.TCPServer` (pythonGH-120488)

Co-authored-by: Vinay Sajip <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@idankap @vsajip @noahbkim
pythongh-120485: Add an override of allow_reuse_port on classes sub…
fec1185 
…classing `socketserver.TCPServer` (pythonGH-120488)

Co-authored-by: Vinay Sajip <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@idankap @vsajip @estyxx
pythongh-120485: Add an override of allow_reuse_port on classes sub…
da075f2 
…classing `socketserver.TCPServer` (pythonGH-120488)

Co-authored-by: Vinay Sajip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idankap @bedevere-bot @vsajip