Skip to content

gh-119826: ntpath.abspath() always return absolute path #119938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 12, 2024
Merged

gh-119826: ntpath.abspath() always return absolute path #119938

merged 13 commits into from
Nov 12, 2024
+35 −18

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Jun 2, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 2, 2024
Closed
@nineteendo nineteendo marked this pull request as ready for review June 2, 2024 11:54
eryksun
eryksun reviewed Jun 2, 2024
View reviewed changes
eryksun
eryksun reviewed Jun 2, 2024
View reviewed changes
nineteendo and others added 2 commits June 2, 2024 14:27
@nineteendo @eryksun
Update Lib/ntpath.py
4a26721 
Co-authored-by: Eryk Sun <[email protected]>
@nineteendo @eryksun
Update Lib/ntpath.py
d2b45fe 
Co-authored-by: Eryk Sun <[email protected]>
eryksun
eryksun reviewed Jun 2, 2024
View reviewed changes
eryksun
eryksun reviewed Jun 3, 2024
View reviewed changes
@nineteendo
Copy link
Contributor Author

cc @zooba

@zooba zooba enabled auto-merge (squash) November 12, 2024 20:45
@zooba
Copy link
Member

zooba commented Nov 12, 2024

Thanks for the contribution! Apologies for taking so long to get to it.

@zooba zooba merged commit 4b00aba into python:main Nov 12, 2024
36 checks passed
@nineteendo nineteendo deleted the fix-ntpath.abspath-2 branch November 13, 2024 06:00
@nineteendo
Copy link
Contributor Author

Do we backport this?

@erlend-aasland
Copy link
Contributor

Do we backport this?

The issue is marked with type-feature; we do not backport features.

@nineteendo
Copy link
Contributor Author

nineteendo commented Nov 13, 2024 •
edited
Loading

The issue should probably be split up in 3:

  1. normpath('C:.'): bug for relative paths
  2. abspath('C:\x00'): always return absolute path
  3. abspath('./con'): support qualified referencing

The third counts as a feature, but I'm not sure about the first two.

@zooba zooba added the needs backport to 3.12 only security fixes label Dec 2, 2024
@zooba zooba added the needs backport to 3.13 bugs and security fixes label Dec 2, 2024
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2024
@nineteendo @miss-islington
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
c190efe 
…ythonGH-119938)

(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2024
@nineteendo @miss-islington
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
ff50ec2 
…ythonGH-119938)

(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127534 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127535 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 2, 2024
@zooba
Copy link
Member

zooba commented Dec 2, 2024

This part of the change is only a bugfix, and only affects currently invalid results, so it's fine to backport. Other PRs attached to the same issue might be considered features (or at least too invasive to backport).

zooba pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @nineteendo
gh-119826: Improved fallback for ntpath.abspath() on Windows (GH-119938)
af2d24b 
(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <[email protected]>
zooba pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @nineteendo
gh-119826: Improved fallback for ntpath.abspath() on Windows (GH-119938)
a853610 
(cherry picked from commit 4b00aba)

Co-authored-by: Nice Zombies <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@nineteendo @picnixz
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
c10dece 
…ythonGH-119938)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@nineteendo @ebonnal
pythongh-119826: Improved fallback for ntpath.abspath() on Windows (p…
6713633 
…ythonGH-119938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eryksun eryksun eryksun left review comments

@erlend-aasland erlend-aasland erlend-aasland left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nineteendo @zooba @erlend-aasland @eryksun