gh-114728: Fix documentation for comparison of objects in datetime module #114749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
docs
hugovk
reviewed
Jan 30, 2024
hugovk
approved these changes
Jan 30, 2024
|
Thank you @hugovk. I asked your review mainly for the case if I made some grammar errors. |
Doc/library/datetime.rst
Outdated
Comment on lines
614
to
616
| :class:`!date` objects that are not also :class:`.datetime` instances | ||
| are never equal to :class:`!datetime` objects, even if they represent | ||
| the same date. |
There was a problem hiding this comment.
Actually, this is not true. See #49766.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2024
…ime module (pythonGH-114749) (cherry picked from commit c12240e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-114928 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2024
…ime module (pythonGH-114749) (cherry picked from commit c12240e) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-114929 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 2, 2024
…time module (GH-114749) (GH-114929) (cherry picked from commit c12240e) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 2, 2024
…time module (GH-114749) (GH-114928) (cherry picked from commit c12240e) Co-authored-by: Serhiy Storchaka <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 1, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 1, 2024
…mparisons if tzinfo is the same (pythonGH-116187) This mostly restores information removed in c12240e (pythonGH-114749). (cherry picked from commit 05b0490) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 1, 2024
…mparisons if tzinfo is the same (pythonGH-116187) This mostly restores information removed in c12240e (pythonGH-114749). (cherry picked from commit 05b0490) Co-authored-by: Serhiy Storchaka <[email protected]>
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…mparisons if tzinfo is the same (pythonGH-116187) This mostly restores information removed in c12240e (pythonGH-114749).
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…mparisons if tzinfo is the same (pythonGH-116187) This mostly restores information removed in c12240e (pythonGH-114749).
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…mparisons if tzinfo is the same (pythonGH-116187) This mostly restores information removed in c12240e (pythonGH-114749).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--114749.org.readthedocs.build/en/114749/library/datetime.html