Skip to content

gh-113655: Revert extra stack reserve in PGO builds unless UseExtraStackReserve=true #114263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2024
Merged

gh-113655: Revert extra stack reserve in PGO builds unless UseExtraStackReserve=true #114263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PCbuild/python.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
<StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize>
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed -->
<StackReserveSize Condition="$(Configuration) == 'PGUpdate'">3000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'PGUpdate' and $(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion PCbuild/pythonw.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
<StackReserveSize Condition="$(Configuration) == 'Debug'">12000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'PGInstrument'">12000000</StackReserveSize>
<!-- HACK: Need additional memory to avoid crashing until gh-113655 is fixed -->
<StackReserveSize Condition="$(Configuration) == 'PGUpdate'">3000000</StackReserveSize>
<StackReserveSize Condition="$(Configuration) == 'PGUpdate' and $(UseExtraStackReserve) == 'true'">3000000</StackReserveSize>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down