gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries #100492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Fidget-Spinner
commented
Dec 24, 2022
•
Fidget-Spinner
commented
- Issue: Finish up LOAD_ATTR specialisation #100288
…ython into more_load_attr
2 tasks
Fidget-Spinner
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 576c914 🤖 If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
The stats show only a small increase in specialization effectiveness, and that the new instruction has a 40% miss rate. I think we would be better off trying to reduce the number of objects with dictionaries than specializing for that case. |
|
Hmm yes hit rate only went from 82.0% to 82.5%. This isn't worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.