Skip to content

Convert more datetime constructors and methods to Argument Clinic #136571

Open
@serhiy-storchaka

Description

@serhiy-storchaka

The datetime module was partially converted to Argument Clinic. The following PR converts more functions. This adds signatures for some classes and methods. As a side effect, this may improve performance.

Usually we avoid behavior changes in conversions to Argument Clinic, but there is one such change in the following PR. Currently, fromisocalendar() always raises ValueError for out of range arguments. After conversion, it will raise OverflowError for values that can't fit in the C int. This is a regression. But all other methods that take integer arguments raise OverflowError. It is better to raise ValueError, but this should be consistent for all methods.

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.15new features, bugs and security fixesextension-modulesC modules in the Modules dirtype-refactorCode refactoring (with no changes in behavior)

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions