Skip to content

Remove unused code related to the removed BINARY_SUBSCR instruction #131306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomasr8 opened this issue Mar 15, 2025 · 0 comments
Closed

Remove unused code related to the removed BINARY_SUBSCR instruction #131306

tomasr8 opened this issue Mar 15, 2025 · 0 comments
Assignees
@tomasr8
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@tomasr8
Copy link
Member

tomasr8 commented Mar 15, 2025 •
edited by bedevere-app bot
Loading

BINARY_SUBSCR was replaced with BINARY_OP and the NB_SUBSCR oparg in #129700 but there is still some code related to BINARY_SUBSCR that I believe can be removed. Some examples:

cpython/Include/internal/pycore_code.h

Lines 121 to 125 in e82c2ca

typedef struct {
_Py_BackoffCounter counter;
} _PyBinarySubscrCache;
#define INLINE_CACHE_ENTRIES_BINARY_SUBSCR CACHE_ENTRIES(_PyBinarySubscrCache)

cpython/Lib/opcode.py

Lines 66 to 68 in e82c2ca

"BINARY_SUBSCR": {
"counter": 1,
},

Linked PRs
@tomasr8 tomasr8 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Mar 15, 2025
@tomasr8 tomasr8 self-assigned this Mar 15, 2025
@bedevere-app bedevere-app bot mentioned this issue Mar 15, 2025
Merged
@picnixz picnixz added the type-feature A feature request or enhancement label Mar 15, 2025
iritkatriel pushed a commit that referenced this issue Mar 16, 2025
@tomasr8
gh-131306: Remove unused code related to BINARY_SUBSCR (#131307)
d07e9eb
@tomasr8 tomasr8 closed this as completed Mar 16, 2025
plashchynski pushed a commit to plashchynski/cpython that referenced this issue Mar 17, 2025
@tomasr8 @plashchynski
pythongh-131306: Remove unused code related to BINARY_SUBSCR (pytho…
e2e8bb9 
…n#131307)
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@tomasr8 @seehwan80
pythongh-131306: Remove unused code related to BINARY_SUBSCR (pytho…
a6b3dbe 
…n#131307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasr8 tomasr8

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomasr8 @picnixz