Skip to content

Colorize tests fail on iOS Xcode 16.2 #130293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
freakboy3742 opened this issue Feb 19, 2025 · 0 comments
Closed

Colorize tests fail on iOS Xcode 16.2 #130293

freakboy3742 opened this issue Feb 19, 2025 · 0 comments
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes OS-ios type-bug An unexpected behavior, bug, or error

Comments

@freakboy3742
Copy link
Contributor

freakboy3742 commented Feb 19, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The iOS buildbot was recently updated to run on Sequoia, with Xcode 16.2 and an iOS 18.2 simulator. This has revealed a set of test failures that weren't occurring on Xcode 15.4 and iOS 17.2:

The failures are all in the test__colorize tests:

test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) ...  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'FORCE_COLOR': ''}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'NO_COLOR': ''}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'PYTHON_COLORS': 'x'}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'PYTHON_COLORS': ''}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'PYTHON_COLORS': '1'}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'PYTHON_COLORS': '0'}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'PYTHON_COLORS': 'x'}, fallback=True) ... FAIL  
  test_colorized_detection_checks_for_environment_variables (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_environment_variables) (env={'PYTHON_COLORS': ''}, fallback=True) ... FAIL
test_colorized_detection_checks_for_file (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_file) ... FAIL
test_colorized_detection_checks_for_std_streams (test.test__colorize.TestColorizeFunction.test_colorized_detection_checks_for_std_streams) ... FAIL

Example failed run: https://buildbot.python.org/#/builders/1380/builds/2619

This is likely due to a conflict between the iOS testbed forcing NO_COLOR, because an iOS log stream doesn't support ANSI logging sequences - but it's not clear why this didn't manifest previously.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other

Linked PRs
@freakboy3742 freakboy3742 added 3.13 bugs and security fixes 3.14 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error OS-ios labels Feb 19, 2025
@freakboy3742 freakboy3742 changed the title Colorize tests fail on Xcode 16.2 Colorize tests fail on iOS Xcode 16.2 Feb 19, 2025
@bedevere-app bedevere-app bot mentioned this issue Feb 20, 2025
Merged
freakboy3742 added a commit that referenced this issue Feb 20, 2025
@freakboy3742
gh-130293: Ensure test__colorize will pass on dumb terminals. (#130333)
1b07006 
Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 20, 2025
@freakboy3742 @miss-islington
pythongh-130293: Ensure test__colorize will pass on dumb terminals. (p…
b36214b 
…ythonGH-130333)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)
Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app bedevere-app bot mentioned this issue Feb 20, 2025
Merged
freakboy3742 added a commit that referenced this issue Feb 20, 2025
@miss-islington @freakboy3742
[3.13] gh-130293: Ensure test__colorize will pass on dumb terminals. (G…
439cba7 
…H-130333) (#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Mar 16, 2025
@miss-islington @freakboy3742
[3.11] pythongh-130293: Ensure test__colorize will pass on dumb termi…
d0fb938 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Mar 16, 2025
@miss-islington @freakboy3742
[3.10] pythongh-130293: Ensure test__colorize will pass on dumb termi…
7ac097f 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this issue Mar 16, 2025
@miss-islington @freakboy3742
[3.9] pythongh-130293: Ensure test__colorize will pass on dumb termin…
ad3288d 
…als. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
@freakboy3742 freakboy3742 mentioned this issue Mar 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes OS-ios type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@freakboy3742