Skip to content

typing.evaluate_forward_ref is not fully covered #128661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Jan 9, 2025 · 1 comment
Closed

typing.evaluate_forward_ref is not fully covered #128661

sobolevn opened this issue Jan 9, 2025 · 1 comment
Assignees
@sobolevn
Labels
3.14 new features, bugs and security fixes tests Tests in the Lib/test dir topic-typing

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 9, 2025 •
edited by bedevere-app bot
Loading

Right now it is:
Снимок экрана 2025-01-09 в 11 36 03

I have a PR ready.

Linked PRs
@sobolevn sobolevn added tests Tests in the Lib/test dir topic-typing 3.14 new features, bugs and security fixes labels Jan 9, 2025
@sobolevn sobolevn self-assigned this Jan 9, 2025
@sobolevn
Copy link
Member Author

sobolevn commented Jan 9, 2025

Aaaand I found a bug!

cpython/Lib/typing.py

Lines 1021 to 1030 in a1284e9

def evaluate_forward_ref(
forward_ref,
*,
owner=None,
globals=None,
locals=None,
type_params=None,
format=annotationlib.Format.VALUE,
_recursive_guard=frozenset(),
):

type_params here is None, not _sentinel, so the deprecation warning is never shown.

sobolevn added a commit to sobolevn/cpython that referenced this issue Jan 9, 2025
@sobolevn
pythongh-128661: Fix typing.evaluate_forward_ref not showing deprec…
120915a 
…ataion
sobolevn added a commit to sobolevn/cpython that referenced this issue Jan 9, 2025
@sobolevn
pythongh-128661: Fix typing.evaluate_forward_ref not showing deprec…
17e7645 
…ataion
@bedevere-app bedevere-app bot mentioned this issue Jan 9, 2025
Merged
sobolevn added a commit that referenced this issue Jan 9, 2025
@sobolevn
gh-128661: Fix typing.evaluate_forward_ref not showing deprecation (#…
b725297 
…128663)

gh-128661: Fix `typing.evaluate_forward_ref` not showing deprecataion
@sobolevn sobolevn closed this as completed Jan 9, 2025
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue Jan 17, 2025
@JelleZijlstra
pythongh-128661: Remove DeprecationWarning in evaluate_forward_ref
bc68f2e 
It doesn't make sense to use a deprecation for evaluate_forward_ref,
as it is a new function in Python 3.14 and doesn't have compatibility
guarantees.

I considered making it throw an error if type_params it not passed and
there is no owner. However, I think this is too unfriendly for users. The
case where this param is really needed is fairly esoteric and I don't think
this case is worth the pain of forcing users to write "type_params=()".
@bedevere-app bedevere-app bot mentioned this issue Jan 17, 2025
Merged
JelleZijlstra added a commit that referenced this issue Apr 3, 2025
@JelleZijlstra
gh-128661: Remove DeprecationWarning in evaluate_forward_ref (#128930)
5518c2a 
It doesn't make sense to use a deprecation for evaluate_forward_ref,
as it is a new function in Python 3.14 and doesn't have compatibility
guarantees.

I considered making it throw an error if type_params it not passed and
there is no owner. However, I think this is too unfriendly for users. The
case where this param is really needed is fairly esoteric and I don't think
this case is worth the pain of forcing users to write "type_params=()".
seehwan pushed a commit to seehwan/cpython that referenced this issue Apr 16, 2025
@JelleZijlstra @seehwan80
pythongh-128661: Remove DeprecationWarning in evaluate_forward_ref (p…
baef41e 
…ython#128930)

It doesn't make sense to use a deprecation for evaluate_forward_ref,
as it is a new function in Python 3.14 and doesn't have compatibility
guarantees.

I considered making it throw an error if type_params it not passed and
there is no owner. However, I think this is too unfriendly for users. The
case where this param is really needed is fairly esoteric and I don't think
this case is worth the pain of forcing users to write "type_params=()".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
3.14 new features, bugs and security fixes tests Tests in the Lib/test dir topic-typing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn