Skip to content

Raise exception when nesting argument groups and mutually exclusive groups #127133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
savannahostrowski opened this issue Nov 22, 2024 · 0 comments · Fixed by #127186
Closed

Raise exception when nesting argument groups and mutually exclusive groups #127133

savannahostrowski opened this issue Nov 22, 2024 · 0 comments · Fixed by #127186
Assignees
@savannahostrowski
Labels
stdlib Python modules in the Lib dir

Comments

@savannahostrowski
Copy link
Member

savannahostrowski commented Nov 22, 2024 •
edited by bedevere-app bot
Loading

The ability to nest argument groups and mutually exclusive groups was deprecated in 3.11 via #30098.

At present, we raise warnings to let users know this has been deprecated. I'd like to remove the logic since we're now two (going on three) releases from initial deprecation, and doing so will also simplify the logic to support new features, like #55797.

Linked PRs
@savannahostrowski savannahostrowski added the stdlib Python modules in the Lib dir label Nov 22, 2024
@savannahostrowski savannahostrowski self-assigned this Nov 22, 2024
@bedevere-app bedevere-app bot mentioned this issue Nov 23, 2024
Merged
savannahostrowski added a commit to savannahostrowski/cpython that referenced this issue Nov 23, 2024
@savannahostrowski
Merge branch 'main' into pythongh-127133
17556c0
@savannahostrowski savannahostrowski changed the title Remove the (deprecated) ability to nest argument groups and mutually exclusive groups Raise exception when nesting argument groups and mutually exclusive groups Nov 24, 2024
@savannahostrowski savannahostrowski linked a pull request Nov 24, 2024 that will close this issue
GH-127133: Remove ability to nest argument groups & mutually exclusive groups #127186
Merged
@savannahostrowski savannahostrowski moved this to Features in Argparse issues Nov 24, 2024
@savannahostrowski savannahostrowski moved this from Features to Bugs in Argparse issues Nov 24, 2024
iritkatriel pushed a commit that referenced this issue Nov 24, 2024
@savannahostrowski
GH-127133: Remove ability to nest argument groups & mutually exclusiv…
2104bde 
…e groups (#127186)
@github-project-automation github-project-automation bot moved this from Bugs to Doc issues in Argparse issues Nov 24, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
sicherha added a commit to sicherha/powerline that referenced this issue Jan 10, 2025
@sicherha
Fix compatibility with Python 3.14
9739ec5 
Nesting argument groups was deprecated in Python 3.11 and will be
removed in the upcoming Python 3.14:
python/cpython#127133

Trying to add a nested group will trigger a `ValueError`.

To prepare the code for Python 3.14, remove the nested groups and add
all arguments at the top level. The mutual exclusion between `--kill`
and `--foreground`/`--replace` is already checked separately within the
`main()` function in `scripts/powerline-daemon`, so the user-observable
behaviour remains unchanged.
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@savannahostrowski @ebonnal
pythonGH-127133: Remove ability to nest argument groups & mutually ex…
9f87a05 
…clusive groups (python#127186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savannahostrowski savannahostrowski

Labels
stdlib Python modules in the Lib dir
Projects
Argparse issues
Status: Doc issues
Milestone
No milestone
1 participant
@savannahostrowski