Skip to content

Outdated socket.NETLINK_* constants #127072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tungol opened this issue Nov 20, 2024 · 4 comments
Closed

Outdated socket.NETLINK_* constants #127072

tungol opened this issue Nov 20, 2024 · 4 comments
Labels
extension-modules C modules in the Modules dir OS-linux type-feature A feature request or enhancement

Comments

@tungol
Copy link
Contributor

tungol commented Nov 20, 2024

Feature or enhancement

Proposal:

When working through the constants in socket for typeshed, I found that these appear to be obsolete:

NETLINK_ARPD: int  # linux 2.0 to 2.6.12 (EOL August 2005)
NETLINK_ROUTE6: int  # linux 2.2 to 2.6.12 (EOL August 2005)
NETLINK_SKIP: int  # linux 2.0 to 2.6.12 (EOL August 2005)
NETLINK_TAPBASE: int  # linux 2.2 to 2.6.12 (EOL August 2005)
NETLINK_TCPDIAG: int  # linux 2.6.0 to 2.6.13 (EOL December 2005)
NETLINK_W1: int  # linux 2.6.13 to 2.6.17 (EOL October 2006)

The netlink constants are defined in include/linux/netlink.h on linux 2.0 to 3.6. Starting in 3.7 they moved to include/uapi/linux/netlink.h. I've annotated these with the versions of linux where I was able to find them, and confirmed that they're not present in FreeBSD's Netlink implementation either.

I suspect these can be safely removed, but I'm not terribly familiar with Netlink myself.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

@tungol tungol added the type-feature A feature request or enhancement label Nov 20, 2024
@picnixz picnixz added the extension-modules C modules in the Modules dir label Nov 21, 2024
@rruuaanng
Copy link
Contributor

If you wish, they can be removed. Currently they are no longer present in uapi/linux/netlink.h in the master branch. But if I could, I'd like this to be given to me ;)

@tungol
Copy link
Contributor Author

tungol commented Nov 23, 2024

I have no intention to open an MR related to this issue myself, if that's what you mean. If you know what the correct thing to do here is, please go ahead!

If you haven't seen it, you might also be interested in this related issue I opened: #127069

@rruuaanng
Copy link
Contributor

I'll submit a PR to remove them soon. Netlink first appeared in linux1.3, and if I remember correctly. As far as I can remember, no other os to support netlink (FreeBSD only partially compatible.)

gpshead added a commit that referenced this issue Nov 27, 2024
Remove seriously outdated netlink constants.

Co-authored-by: Gregory P. Smith <[email protected]>
@picnixz
Copy link
Member

picnixz commented Nov 27, 2024

Closing since completed.

@picnixz picnixz closed this as completed Nov 27, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
…nGH-127256)

Remove seriously outdated netlink constants.

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension-modules C modules in the Modules dir OS-linux type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants