jit.c may be built with an incomplete jit_stencils.h
#118943
Comments
|
I've test-built the package in the Fedora build system. https://koji.fedoraproject.org/koji/taskinfo?taskID=117554410 (this will eventually be garbage collected) Some architectures succeeded and some failed with: I suppose this is expected. But the problem reported here did not happen. Perhaps it only happens sometimes... ? I will trigger a couple of x86_64 builds to see if I can reproduce this again. |
|
Theory: I noticed we currently don't do an atomic rename of |
|
Out of 10 builds, I did not reproduce this again. |
Yeah, we're not attempting to support anything that isn't at least in PEP 11 right now.
Well, yeah, these ones are intentionally failing early since we won't even attempt to build the JIT. So no By the way, it appears my hunch is correct. With careful use of parallel build and manually inserted So writing to a different file |
brandtbucher
changed the title
jit.c may be built with an incomplete jit_stencils.h
…ythonGH-118957) (cherry picked from commit 4702b7b) Co-authored-by: Brandt Bucher <[email protected]>
…GH-119101) (cherry picked from commit 4702b7b)
|
FWIW I just seen: This is slightly better than before, but still not entirely OK. I guess when this happens, it means another process created and moved the new file at the same time. Perhaps the file needs to have a uniq path, and/or be in tmp? |
|
I got it on x86_64 as well, twice in a row. Both builders had 48 CPUs, so the Should I open a new issue? |
…ils.h Another process might have already moved jit_stencils.h.new
|
I opened #120690 |
…t_stencils.h Another process might have already moved jit_stencils.h.new
…t_stencils.h Another process might have already moved jit_stencils.h.new
…t_stencils.h Another process might have already moved jit_stencils.h.new
Co-authored-by: Kirill Podoprigora <[email protected]>
…0690) (cherry picked from commit 44659d3) Co-authored-by: Miro Hrončok <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]>
…t_stencils.h Another process might have already moved jit_stencils.h.new
…0690) Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Éric <[email protected]>
…honGH-122602) (cherry picked from commit 8c9d174) Co-authored-by: Miro Hrončok <[email protected]> Co-authored-by: Éric <[email protected]>
(cherry picked from commit 44659d3) Co-authored-by: Miro Hrončok <[email protected]> Co-authored-by: Kirill Podoprigora <[email protected]>
…-122840) cherry picked from commit 8c9d174) Co-authored-by: Miro Hrončok <[email protected]> Co-authored-by: Éric <[email protected]>
|
Thanks again, @hroncok! |
…0690) Co-authored-by: Kirill Podoprigora <[email protected]>
…honGH-122602) Co-authored-by: Éric <[email protected]>
Bug report
Bug description:
As discussed in https://discuss.python.org/t/pep-744-jit-compilation/50756/42 and further with @brandtbucher, I've tried to change the Fedora's Python 3.13 package to utilize
--enable-experimental-jit=yes-off.As a starting point, I took the 3.13.0b1-1 package from:
https://src.fedoraproject.org/rpms/python3.13/blob/1c24374362/f/python3.13.spec
And I changed:
That means I added
--enable-experimental-jit=yes-offto the debug and optimized non-free-threaded builds and some extra build dependencies.Running the build in Fedora Rawhide (41) chroot resulted in this error during the debug build (which happens first):
Full logs:
@brandtbucher suggested that "perhaps several builds are happening at once for some reason. If so, they could be stepping on each other and maybe truncating the generated file."
Anyway, here is the generated jit_stencils.h file as it was present after the failure.
CPython versions tested on:
3.13
Operating systems tested on:
Linux
Linked PRs
jit_stencils.h#118957The text was updated successfully, but these errors were encountered: