Skip to content

Upload results XML for warning stable builds #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 12, 2025

Would it make sense to save the JUnit result file for warnings builds, at least for stable builders on the main branch?

This would allow the dashboard to list tests that failed first, then succeeded on the re-run. If that happens in a test that isn't traditionally flaky, it would be good to investigate it.


As for this PR, I don't think this is the proper way to do things, but, I'm not sure what would be a good way. Any pointers would be welcome.

@encukou encukou requested review from ambv and zware June 12, 2025 14:11
@encukou encukou marked this pull request as ready for review June 16, 2025 06:21
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which service is going to consume (remove) these XML files? In the past, these XML files filled the disk.

@zware
Copy link
Member

zware commented Jun 16, 2025

There's a daily cronjob that removes anything from /data/www/buildbot/test-results that is a file older than 1 week. At the moment, there are 2.4GB of XML there and 43GB free, so I wouldn't expect a disk usage issue.

That said, I've never actually used these files, so I don't have much in the way of opinion on whether to upload more of them :). No objection if they're useful to someone.

@encukou
Copy link
Member Author

encukou commented Jun 16, 2025

They're used by the release status dashboard that I look at every day.
(Not that many errors are reported in the XMLs these days though. For an example, see the “AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.11” entry, showing ValueErrors.)

There's a daily cronjob that removes anything from /data/www/buildbot/test-results that is a file older than 1 week

That's perfect :)

@vstinner
Copy link
Member

There's a daily cronjob that removes anything from /data/www/buildbot/test-results that is a file older than 1 week

Oh ok, I'm fine with that.

@encukou encukou merged commit 64ac1c4 into python:main Jun 17, 2025
1 check passed
@encukou encukou deleted the xml-warnings branch June 17, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants