Skip to content

Skip having a PR builder for nondebug WASI #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Skip having a PR builder for nondebug WASI #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions master/master.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ for branch_num, (git_url, branchname, git_branch) in enumerate(git_branches):
# 10pm UTC and 2am UTC, it will be delayed to 2am UTC.
if worker_name == "diegorusso-aarch64-bigmem":
builder.canStartBuild = no_builds_between("22:00", "2:00")

# This worker restarts every day at 9am UTC to work around issues stemming from
# failing bigmem tests trashing disk space and fragmenting RAM. Builds scheduled
# between 07:20am - 9:20am UTC will be delayed to 9:20am UTC.
Expand Down Expand Up @@ -366,10 +366,6 @@ all_pull_request_builders = []

for name, worker_name, buildfactory, stability, tier in BUILDERS:
buildername = f"{name} PR"
all_pull_request_builders.append(buildername)
if stability == STABLE:
stable_pull_request_builders.append(buildername)

source = GitHub(repourl=git_url, **GIT_KWDS)

f = buildfactory(
Expand All @@ -386,6 +382,14 @@ for name, worker_name, buildfactory, stability, tier in BUILDERS:
if tier:
tags.append(tier)

# The nondebug WASI builder does not work across all Python versions
# due to some file locations being different and `wasi.py` not being
# available.
# As such, it's just easier to skip the builder entirely for PRs.
# This can be removed once we are only supporting >= 3.13.
if "wasm" in tags and "nondebug" in tags:
continue

builder = util.BuilderConfig(
name=buildername,
workernames=[worker_name],
Expand All @@ -402,6 +406,9 @@ for name, worker_name, buildfactory, stability, tier in BUILDERS:
builder.canStartBuild = no_builds_between("22:00", "2:00")

c["builders"].append(builder)
all_pull_request_builders.append(buildername)
if stability == STABLE:
stable_pull_request_builders.append(buildername)

c["schedulers"].append(
GitHubPrScheduler(
Expand Down