Skip to content

Add missing arguments to run_process #3212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 13, 2025

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Feb 16, 2025

Fixes #3183

I tried out TypedDict here like @decorator-factory recommended and it's nicer, though it's explicitly trading off user experience:

  • no defaults listed
  • wacky reveal_type at least under mypy

I think it's worth it? I doubt people are looking at overloads for the defaults to things.

I still need to add type tests.

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (d63f3a9) to head (6eb1ba1).
Report is 186 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff                @@
##                 main        #3212    +/-   ##
================================================
  Coverage   100.00000%   100.00000%            
================================================
  Files             124          124            
  Lines           18764        18990   +226     
  Branches         1269         1302    +33     
================================================
+ Hits            18764        18990   +226     
Files with missing lines Coverage Δ
src/trio/_subprocess.py 100.00000% <100.00000%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A5rocks A5rocks changed the title Update run process Add missing arguments to run_process Feb 16, 2025
Copy link
Member

@jakkdl jakkdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked terribly close at the arguments, but seems fine at a glance.
In an ideal world it'd maybe be nice to have tests.. but it sounds messy to write something that validates against typeshed signatures and handles version/platform differences.

@A5rocks A5rocks added this pull request to the merge queue Mar 13, 2025
Merged via the queue into python-trio:main with commit 68014ec Mar 13, 2025
43 checks passed
@A5rocks A5rocks deleted the update-run-process branch March 13, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add executable kwarg to trio.run_process type hints
2 participants