Refactor docs Makefile
#8933
Merged
Refactor docs Makefile
#8933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Apr 27, 2025
|
|
||
| # Internal variables. | ||
| PAPEROPT_a4 = --define latex_paper_size=a4 | ||
| PAPEROPT_letter = --define latex_paper_size=letter | ||
| ALLSPHINXOPTS = --doctree-dir $(BUILDDIR)/doctrees $(PAPEROPT_$(PAPER)) $(SPHINXOPTS) . | ||
| # the i18n builder cannot share the environment and doctrees with the others | ||
| I18NSPHINXOPTS = $(PAPEROPT_$(PAPER)) $(SPHINXOPTS) . |
There was a problem hiding this comment.
Ah, right, I18NSPHINXOPTS is unused due to #8917
radarhere
reviewed
Apr 29, 2025
radarhere
approved these changes
Apr 29, 2025
Co-authored-by: Andrew Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to remove duplication.
Some functional changes:
--jobs autofor all builders, not justlinkcheck. This speedsmake -C docs clean htmlfor me from 25 seconds to 14 seconds.--fail-on-warning --keep-goingfor all builders, not justhtml.