Handle IPTC TIFF tags with incorrect type #8925
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8923
#8315 replaced
im.tag.tagdata[TiffImagePlugin.IPTC_NAA_CHUNK]
withim.tag_v2[TiffImagePlugin.IPTC_NAA_CHUNK]
, but didn't think to ask why.tagdata
was used, rather than justim.tag[TiffImagePlugin.IPTC_NAA_CHUNK]
. The answer would have been in this comment.Pillow/src/PIL/IptcImagePlugin.py
Lines 219 to 220 in 58e4874
This would have been referring to the same phenomenon as https://web.archive.org/web/20240221164915/https://www.awaresystems.be/imaging/tiff/tifftags/iptc.html
This fixes the issue by switching to
im.tag_v2._tagdata[TiffImagePlugin.IPTC_NAA_CHUNK]