ImageMath: Only compute ops
dict when needed
#7718
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea to fix #7717, only compute the
ops
dict when needed, when first callingeval
, andfunctools.lru_cache
it so it's only computed once.Also rewrite as a dict comprehension. Timings for non-cached use:
200000 loops, best of 5: 1.87 usec per loop
->
200000 loops, best of 5: 1.53 usec per loop