Skip to content

RFC: Specify Version in one place #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 29, 2017

Conversation

wiredfool
Copy link
Member

Changes proposed in this pull request:

  • Improves the release process by having one place to change the version number for Pillow, then including that value elsewhere, when required.
  • Does not update the appveyor version number. I'm wondering if just a build is ok there.

@hugovk
Copy link
Member

hugovk commented May 10, 2017

It's nice to have the version number in AppVeyor, it makes things 100% clear what's building, but it's not essential: we don't have it on Travis CI.

@hugovk
Copy link
Member

hugovk commented May 12, 2017

Windows isn't happy.

@wiredfool
Copy link
Member Author

Yeah, I know. I've got to fire up the windows box and have a look.

@python-pillow python-pillow deleted a comment from codecov bot Jun 21, 2017
@python-pillow python-pillow deleted a comment from codecov bot Jun 21, 2017
@python-pillow python-pillow deleted a comment from codecov bot Jun 21, 2017
@python-pillow python-pillow deleted a comment from codecov bot Jun 21, 2017
@codecov
Copy link

codecov bot commented Jun 21, 2017

Codecov Report

Merging #2517 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2517      +/-   ##
==========================================
+ Coverage   82.03%   82.03%   +<.01%     
==========================================
  Files         162      163       +1     
  Lines       20992    20995       +3     
  Branches     2607     2606       -1     
==========================================
+ Hits        17220    17223       +3     
  Misses       3772     3772
Impacted Files Coverage Δ
PIL/Image.py 90.08% <ø> (ø) ⬆️
_imaging.c 86.52% <100%> (+0.01%) ⬆️
PIL/__init__.py 100% <100%> (ø) ⬆️
PIL/version.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014be86...45ed1a8. Read the comment docs.

@wiredfool
Copy link
Member Author

Apparently codecov really wants a comment on this PR.

Anyway, I've got it building on all the CI versions. Removed the version from Appveyor.yml. Works on clang/osx as well, so major platforms are all covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants