-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
RFC: Specify Version in one place #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's nice to have the version number in AppVeyor, it makes things 100% clear what's building, but it's not essential: we don't have it on Travis CI. |
Windows isn't happy. |
Yeah, I know. I've got to fire up the windows box and have a look. |
7b0f5fe
to
edc8d86
Compare
Codecov Report
@@ Coverage Diff @@
## master #2517 +/- ##
==========================================
+ Coverage 82.03% 82.03% +<.01%
==========================================
Files 162 163 +1
Lines 20992 20995 +3
Branches 2607 2606 -1
==========================================
+ Hits 17220 17223 +3
Misses 3772 3772
Continue to review full report at Codecov.
|
327edd1
to
45ed1a8
Compare
Apparently codecov really wants a comment on this PR. Anyway, I've got it building on all the CI versions. Removed the version from Appveyor.yml. Works on clang/osx as well, so major platforms are all covered. |
Changes proposed in this pull request: