Improved RpmPackage is_installed property logic.

test/test_modules.py

@@ -13,6 +13,7 @@
 import crypt
 import datetime
 import os
+from unittest import mock
 import re
 import time
 from ipaddress import IPv4Address, IPv6Address, ip_address
@@ -58,6 +59,19 @@ def test_held_package(host):
     assert python.is_installed
     assert python.version.startswith("3.11.")
 
+@pytest.mark.testinfra_hosts("docker://rockylinux9")
+def test_rpmdb_corrupted(host):
+    host.check_output("mv /var/lib/rpm/rpmdb.sqlite /var/lib/rpm/rpmdb.sqlite.bck")
+    try:
+        host.check_output("dd if=/dev/zero of=/var/lib/rpm/rpmdb.sqlite bs=1024 count=1")
+        with pytest.raises(RuntimeError) as excinfo:
+            host.package("zsh").is_installed
+        assert (
+            f"Could not check if RPM package 'zsh' is installed. "
+            "error: sqlite failure:"
+        ) in str(excinfo.value)
+    finally:
+        host.check_output("mv /var/lib/rpm/rpmdb.sqlite.bck /var/lib/rpm/rpmdb.sqlite")
 
 @pytest.mark.testinfra_hosts("docker://rockylinux9")
 def test_non_default_package_tool(host):

testinfra/modules/package.py

@@ -165,7 +165,13 @@ def version(self):
 class RpmPackage(Package):
     @property
     def is_installed(self):
-        return self.run_test("rpm -q %s", self.name).rc == 0
+        result = self.run_test("rpm -q --quiet %s 2>&1", self.name)
+        if result.succeeded:
+            return True
+        elif result.failed and result.stdout == '':
+            return False
+        else:
+            raise RuntimeError(f"Could not check if RPM package '{self.name}' is installed. {result.stdout}")
 
     @property
     def version(self):