Skip to content

Fix recursion on dynamic import from fake file #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

Fix recursion on dynamic import from fake file #1144

merged 1 commit into from
Mar 15, 2025
+20 −2

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Mar 15, 2025 •
edited
Loading

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing

mrbean-bremen
mrbean-bremen commented Mar 15, 2025
View reviewed changes
@mrbean-bremen
Fix recursion on dynamic import from fake file
dde25d2 
- happened in Python > 3.11 due to the handling of linecache
  in connection with a faked open_code call
- fixes pytest-dev#1121
@mrbean-bremen mrbean-bremen merged commit 0d5d2b1 into pytest-dev:main Mar 15, 2025
121 checks passed
@mrbean-bremen mrbean-bremen deleted the dyn-import branch June 3, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RecursionError if a fake module imports another fake module
1 participant
@mrbean-bremen