Skip to content

tests: use modern tmp_path instead of py.path based tmpdir #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Mar 10, 2023

This uses pathlib-based tmp_path instead of py.path based tmpdir fixtures. Should be fine for pytest 6+, I think. Came up in the context of #512, though you can't quite remove the _pytest warning suppression, as there's one remaining thing in pytest that is missing an encoding.

@agronholm
Copy link
Contributor

I actually made this change in the publicapi branch. I expected that work to proceed faster than it actually has 😃

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0de0c1a) 68.35% compared to head (1b69248) 68.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   68.35%   68.35%           
=======================================
  Files          12       12           
  Lines         929      929           
=======================================
  Hits          635      635           
  Misses        294      294           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@agronholm agronholm merged commit fb33195 into pypa:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants