Fix get_embed_wheel for unknown wheels #2877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_embed_wheel()` no longer fails with `TypeError: unsupported operand type(s) for /: 'PosixPath' and 'NoneType'` for unsupport distributions. Callers like `load_embed_wheel()` and `get_wheel()` are handling `None` correctly. The fix simplifies custom seed plugins. They no longer have to monkey-patch `BUNDLE_SUPPORT`. See https://github.com/sclabs/virtualenv-seedhelper/blob/v0.0.1/virtualenv_seedhelper.py#L53-L56 Signed-off-by: Christian Heimes <[email protected]>
gaborbernat
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_embed_wheel()no longer fails withTypeError: unsupported operand type(s) for /: 'PosixPath' and 'NoneType'for unsupport distributions. Callers likeload_embed_wheel()andget_wheel()are handlingNonecorrectly.The fix simplifies custom seed plugins. They no longer have to monkey-patch
BUNDLE_SUPPORT. Seehttps://github.com/sclabs/virtualenv-seedhelper/blob/v0.0.1/virtualenv_seedhelper.py#L53-L56
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolder