Update test_wheel.WheelTestCase.test_abi for freethreading
#244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `test_wheel.WheelTestCase.test_abi` to account for the `t` suffix added in freethreaded CPython builds. Fixes pypa#243
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 81.49% 81.60% +0.11%
==========================================
Files 24 24
Lines 8885 8960 +75
Branches 1747 1537 -210
==========================================
+ Hits 7241 7312 +71
- Misses 1300 1309 +9
+ Partials 344 339 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Took a few more changes but we have testing on 3.13t now, and it works on Windows too. I've also enabled testing on new PyPy versions while I was modifying GHA. |
|
Thank you for this. |
|
Thanks! Glad I got it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
test_wheel.WheelTestCase.test_abito account for thetsuffix added in freethreaded CPython builds.Fixes #243