Skip to content

Update to PyPy 7.3.3 #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2020
Merged

Update to PyPy 7.3.3 #460

merged 5 commits into from
Nov 22, 2020

Conversation

YannickJadoul
Copy link
Member

The first release candidate for PyPy 7.3.3 has been released. Preparing for a hopefully painless update :-)

CC @mattip, if interested in our tests.

@mattip
Copy link
Contributor

mattip commented Nov 11, 2020

The windows sysconfig.py install scheme changed from bin/pypy*exe to Scripts/pypy*exe to bring PyPy into line with CPython, but I guess you don't make virtualenvs here

@YannickJadoul
Copy link
Member Author

but I guess you don't make virtualenvs here

We do, actually, to run the tests of a package. I recall something about symlinks, but let me check.

On another note: in our example CI configurations, we have a line # PyPy 7.3.2 needs macOS >= 10.14 (and select a recent enough version of the CI macOS images). Do you know if this is still the case for 7.3.3, or is it worth trying this out again?

@mattip
Copy link
Contributor

mattip commented Nov 11, 2020

🤷

We did fix some things around macOSx building, maybe try it out if it is not too painful?

@YannickJadoul
Copy link
Member Author

but I guess you don't make virtualenvs here

We do, actually, to run the tests of a package. I recall something about symlinks, but let me check.

We had a workaround (symlinking Scripts to point to bin), but it seems this was already removed in #304 (the update to PyPy 7.3.1; see this line of one of the commits, commit d7629ad).

Any further pointers on what has changed now, or why we didn't have issues with this?

At first glance, I don't see a lot of other "workarounds" left, needed to plug in PyPy instead of CPython :-)
(Maybe the symlink of python.exe to pypy.exe or pypy3.exe to be able to just use python; but that's arguably not even a workaround.)

@mattip
Copy link
Contributor

mattip commented Nov 11, 2020

Any further pointers on what has changed now, or why we didn't have issues with this?

This release is meant to be a cleanup and tweaks for the C-API for various packages, there should be no breaking changes.

@YannickJadoul
Copy link
Member Author

On another note: in our example CI configurations, we have a line # PyPy 7.3.2 needs macOS >= 10.14 (and select a recent enough version of the CI macOS images). Do you know if this is still the case for 7.3.3, or is it worth trying this out again?

We did fix some things around macOSx building, maybe try it out if it is not too painful?

@mattip, Travis CI just passed on macOS, running 10.13 (https://travis-ci.org/github/joerick/cibuildwheel/jobs/743064327#L17), and CircleCI is also passing, so that does seem to be fixed, as well :-)

…e examples to use macOS >= 10.14"

This reverts commits 870bf3f and cd53552.
@YannickJadoul
Copy link
Member Author

Hurray, 7.3.3 was released. Waiting for pypy/manylinux#11 to be merged, before reverting yannickjadoul/manylinux2010-pypy_x86_64 to pypywheels/manylinux2010-pypy_x86_64.

@YannickJadoul YannickJadoul marked this pull request as ready for review November 22, 2020 12:23
@YannickJadoul
Copy link
Member Author

Ready! :-)

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too!

@YannickJadoul
Copy link
Member Author

Hurray. Thanks, both! Let's merge this, then!

@YannickJadoul YannickJadoul merged commit 2f4ed1f into pypa:master Nov 22, 2020
@YannickJadoul YannickJadoul deleted the pypy-7.3.3 branch November 22, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants