Skip to content

Debug Cirrus CI testing #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 29, 2025
Merged

Debug Cirrus CI testing #2414

merged 10 commits into from
May 29, 2025

Conversation

joerick
Copy link
Contributor

@joerick joerick commented May 25, 2025

Fix the build on main.

Disables iOS testing on Cirrus.

Cirrus has a problem running the simulator, see a recent build on main, for example:

https://cirrus-ci.com/task/6394806932340736?logs=run_cibuildwheel_tests#L1832

I've removed the support tick from cirrus in the readme too, until/unless we can figure this out.

cc @freakboy3742

Fixes a bug with the GraalPy build

Sometimes vsdevcmd can print an error to console while it works. This messed up the environment JSON blob, so it's saved to a file instead.

@freakboy3742
Copy link
Contributor

AFAICT, this is a manifestation of python/cpython#133131 - Xcode removed the iPhone SE simulator from the default set when they released Xcode 16.3, in favor of the newly released "iPhone 16e". As a result, the default simulator picked by the iOS testbed runner no longer exists.

This has been fixed upstream, and the patch will be rolled into the next release of the iOS binary support package. I was planning to cut an update once 3.14 beta 2 is released (which is due in a day or two).

@henryiii
Copy link
Contributor

Beta 2 is out now! Also waiting on @mayut to trigger manylinux.

@freakboy3742
Copy link
Contributor

Beta 2 is out now! Also waiting on @mayut to trigger manylinux.

ACK - still trying to dig my way out of my Pycon US backlog. Will cut a new release as soon as I surface :-)

@joerick
Copy link
Contributor Author

joerick commented May 28, 2025

I think you meant @mayeut above!

@joerick joerick changed the title Skip Cirrus CI iOS testing Debug Cirrus CI testing May 28, 2025
@joerick
Copy link
Contributor Author

joerick commented May 28, 2025

Whomp whomp, ran out of cirrus credits. I'm pretty sure i figured out what was wrong, vsdevcmd was outputting an error message that was corrupting the JSON stream. I'll tidy this up.

@joerick joerick marked this pull request as draft May 28, 2025 17:53
@joerick joerick marked this pull request as ready for review May 28, 2025 20:23
@joerick joerick added CI: PyPy Run the integration test suite with PyPy included CI: GraalPy Run the integration test suite with GraalPy included and removed CI: GraalPy Run the integration test suite with GraalPy included labels May 28, 2025
@joerick
Copy link
Contributor Author

joerick commented May 29, 2025

This is in fact, ready, the Cirrus CI failures are due to lack of credits.

@joerick joerick requested a review from Copilot May 29, 2025 11:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI test failures by disabling iOS testing on Cirrus CI, streamlines skip logic in the iOS tests, and improves the GraalPy environment capture process on Windows. It also updates the README to reflect Cirrus CI's unsupported iOS testing status.

  • Centralize and apply skip_if_ios_testing_not_supported in test/test_ios.py
  • Change GraalPy setup to write environment JSON to a file in cibuildwheel/platforms/windows.py
  • Remove Cirrus CI iOS support indicator in README.md

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/test_ios.py Added skip_if_ios_testing_not_supported helper and replaced inline skips, disabling iOS tests on Cirrus CI
cibuildwheel/platforms/windows.py Capture GraalPy environment via a temporary JSON file instead of check_output
README.md Cleared the Cirrus CI support tick to indicate unsupported iOS testing

@henryiii henryiii merged commit 733573f into main May 29, 2025
45 of 69 checks passed
@henryiii henryiii deleted the cirrus-debug branch May 29, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: GraalPy Run the integration test suite with GraalPy included CI: PyPy Run the integration test suite with PyPy included
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants