-
Notifications
You must be signed in to change notification settings - Fork 277
Debug Cirrus CI testing #2414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug Cirrus CI testing #2414
Conversation
AFAICT, this is a manifestation of python/cpython#133131 - Xcode removed the iPhone SE simulator from the default set when they released Xcode 16.3, in favor of the newly released "iPhone 16e". As a result, the default simulator picked by the iOS testbed runner no longer exists. This has been fixed upstream, and the patch will be rolled into the next release of the iOS binary support package. I was planning to cut an update once 3.14 beta 2 is released (which is due in a day or two). |
Beta 2 is out now! Also waiting on @mayut to trigger manylinux. |
ACK - still trying to dig my way out of my Pycon US backlog. Will cut a new release as soon as I surface :-) |
I think you meant @mayeut above! |
Whomp whomp, ran out of cirrus credits. I'm pretty sure i figured out what was wrong, vsdevcmd was outputting an error message that was corrupting the JSON stream. I'll tidy this up. |
This is in fact, ready, the Cirrus CI failures are due to lack of credits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes CI test failures by disabling iOS testing on Cirrus CI, streamlines skip logic in the iOS tests, and improves the GraalPy environment capture process on Windows. It also updates the README to reflect Cirrus CI's unsupported iOS testing status.
- Centralize and apply
skip_if_ios_testing_not_supported
intest/test_ios.py
- Change GraalPy setup to write environment JSON to a file in
cibuildwheel/platforms/windows.py
- Remove Cirrus CI iOS support indicator in
README.md
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
test/test_ios.py | Added skip_if_ios_testing_not_supported helper and replaced inline skips, disabling iOS tests on Cirrus CI |
cibuildwheel/platforms/windows.py | Capture GraalPy environment via a temporary JSON file instead of check_output |
README.md | Cleared the Cirrus CI support tick to indicate unsupported iOS testing |
Fix the build on
main
.Disables iOS testing on Cirrus.
Cirrus has a problem running the simulator, see a recent build on main, for example:
https://cirrus-ci.com/task/6394806932340736?logs=run_cibuildwheel_tests#L1832
I've removed the support tick from cirrus in the readme too, until/unless we can figure this out.
cc @freakboy3742
Fixes a bug with the GraalPy build
Sometimes vsdevcmd can print an error to console while it works. This messed up the environment JSON blob, so it's saved to a file instead.