feat: move default manylinux build to manylinux_2_28 #2330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
force-pushed
the
default-manylinux_2_28
branch
from
a7e9536 to
1c90b80
Compare
henryiii
approved these changes
Mar 24, 2025
|
Awesome! Glad to see this move was made! |
alexlancaster
added a commit
to alexlancaster/pypop
that referenced
this pull request
Mar 27, 2025
…llinux` segfaults (#272) * use `manylinux_2_28` as the default image testing as this will be the new default starting with `cibuildwheel` 3.0 (pypa/cibuildwheel#2330) * re-enable cp313 on `musllinux` for x86 * cleanup pyproject.toml * changes to eliminate warnings from SWIG wrapper * add an `x86_64` platform for `musllinux` wheel in default CI * found source of `musllinux` crash: off-by-1 memory allocation for `like_ratio` array * Haplo module: always set default `numPermutations` to 1: even when no permutation test is to be run, this is used to allocatethe initial array * turn off skipping of tests on `musllinux` by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1772
closes #1988
The rational for doing this is in #1988 with some timeline discussions in #1772 & #2047.