Skip to content

Sanitise environment variables against template injection #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Jul 1, 2025

This is something I ought to have done in #148, but I later realised that this was risky, and it also fixes builds for packages outside of SciPy. Otherwise, it is possible for those with malicious intent to inject unsafe code into GHA runners. It doesn't directly affect us as the attack surface is low, but in this case it was a functional bug as well, as the backticks in the PR title were being interpreted literally in #149.

@agriyakhetarpal agriyakhetarpal merged commit cd64f10 into pyodide:main Jul 1, 2025
2 checks passed
@agriyakhetarpal agriyakhetarpal deleted the sanitise-env-vars branch July 1, 2025 08:46
Copy link

github-actions bot commented Jul 1, 2025

Package Build Results

Total packages built: 28
Total build time: 0:02:41

Package Build Times (click to expand)
Package Build Time
openssl 2m 37s
sqlite3 1m 15s
liblzma 1m 4s
test 26s
regex 13s
MarkupSafe 4s
pydoc_data 4s
pydecimal 4s
lzma 4s
ssl 4s
atomicwrites 3s
hashlib 3s
packaging 2s
pyparsing 1s
attrs 1s
pytz 1s
tblib 1s
iniconfig 1s
more-itertools 1s
pluggy 1s
six 1s
py 1s
micropip 1s
setuptools 1s
Jinja2 1s
pytest 1s
pytest-asyncio 0s
exceptiongroup 0s

Longest build: openssl (2m 37s)
Packages built in more than 10 minutes: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant