Skip to content

Fix test_click_click_object_definition on macOS, and use temporary paths for generating plugins #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2025
Merged

Fix test_click_click_object_definition on macOS, and use temporary paths for generating plugins #40

merged 4 commits into from
Apr 4, 2025

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Apr 4, 2025 •
edited
Loading

  • macOS uses spawn as the start method by default, and nested functions can't be pickled
  • use temporary paths with generated plugins
  • add macOS for testing (this test failed and wasn't caught in CI)
  • use Python 3.12 for testing – I'll bump the minimum required version to 3.12 in another PR after this

@agriyakhetarpal agriyakhetarpal changed the title Fix test_click_click_object_defintion on macOS Fix test_click_click_object_definition on macOS, and use temporary paths for generating plugins Apr 4, 2025
@agriyakhetarpal agriyakhetarpal marked this pull request as ready for review April 4, 2025 23:49
@agriyakhetarpal agriyakhetarpal merged commit 026e8fb into pyodide:main Apr 4, 2025
4 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/macos-tests branch April 4, 2025 23:50
@ryanking13
Copy link
Member

Thanks for improving the cli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agriyakhetarpal @ryanking13