update Or Bahari copyright aliases

[orSolocate]

Type of Changes

	Type
	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
✓	📜 Docs

Description

Update Or Bahari (myself) email aliases.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (2f9af7d) to head (62d3b02).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10432   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files         176      176           
  Lines       19137    19137           
=======================================
  Hits        18347    18347           
  Misses        790      790           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Pierre-Sassoulas]

This is going to create two different entry in the changelog, is this really what you want ?

[orSolocate]

This is going to create two different entry in the changelog, is this really what you want ?

@Pierre-Sassoulas I don't think we need any changelog here as it is only a minor internal change.. What do I need to do to achieve that?

[Pierre-Sassoulas]

Sorry I meant in the contributor file.

[Pierre-Sassoulas]

The current config is the best way to "hide" this email, as it's public information contained in the git history, it's going to be displayed as two different persons in the next release, if we apply this.

[orSolocate]

@Pierre-Sassoulas okay, so does it mean that the contributor list is per email address, and not per name/GitHub user? Naturally thinking, I would expect it to be per GitHub user or contributor's name (even though either are modifiable, as well as using a different email address I guess). What is your take on this? Is there a potential bug in the config here? Is it worth the discussion?
Anyhow, in the current aliases config we probably prefer to drop this issue, right?

[Pierre-Sassoulas]

The git history is based on what was configured locally in git at time of commit (two strings, one for Author, one for email, user chosen, not checked, set in stone once merged in a public branch), github is a layer on top of it, that permits to associate multiple emails to your github account. This json conf is like github: it permits to associate multiple email (to one person instead of one github account). I would suggest closing, yes.