Skip to content

Fix dev requirements #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jan 30, 2023

Description

We recently upgraded isort to 5.12.0 without realizing that, similar to flake8, they dropped support for Python 3.7.
The requirements_test_pre_commit.txt file wasn't included in the cache key, thus the old cache was reused without actually installing 5.12.0 into the CI environment.

Pre-commit.ci uses the version from pre-commit-config so that was fine.

This PR also updates the version for flake8 to get in sync to our pre-commit config.

--
Tbh as more and more tools start to drop 3.7, I'm not opposed to doing the same. Maybe after the 2.16.0 release?
Pylint could still be used to lint 3.7 code, only run with Python 3.8.

Failing test from #1992: https://github.com/PyCQA/astroid/actions/runs/4046304756/jobs/6958923838

@cdce8p cdce8p added dependency Related to dependencies of the project backport maintenance/2.13.x labels Jan 30, 2023
@cdce8p cdce8p added this to the 2.13.4 milestone Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1993 (f4772df) into main (156db06) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1993   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          94       94           
  Lines       10931    10931           
=======================================
  Hits        10141    10141           
  Misses        790      790           
Flag Coverage Δ
linux 92.53% <ø> (ø)
pypy 88.50% <ø> (ø)
windows 92.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 03f3ad9 into pylint-dev:main Jan 30, 2023
@github-actions
Copy link
Contributor

The backport to maintenance/2.13.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.13.x maintenance/2.13.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.13.x
# Create a new branch
git switch --create backport-1993-to-maintenance/2.13.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03f3ad95b61cf802f484b2515bf7f3cc8d744435
# Push it to GitHub
git push --set-upstream origin backport-1993-to-maintenance/2.13.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.13.x

Then, create a pull request where the base branch is maintenance/2.13.x and the compare/head branch is backport-1993-to-maintenance/2.13.x.

@cdce8p cdce8p deleted the fix-dev-requirements branch January 30, 2023 18:38
Pierre-Sassoulas pushed a commit that referenced this pull request Jan 30, 2023
Cherry-picked for the 2.13.x maintenance branch
Pierre-Sassoulas added a commit that referenced this pull request Jan 30, 2023
Cherry-picked for the 2.13.x maintenance branch

Co-authored-by: Marc Mueller <[email protected]>
@cdce8p cdce8p added the backported Assigned once the backport is done label Jan 31, 2023
@cdce8p cdce8p modified the milestone: 2.13.4 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done dependency Related to dependencies of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants