Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently upgraded isort to
5.12.0
without realizing that, similar to flake8, they dropped support for Python 3.7.The
requirements_test_pre_commit.txt
file wasn't included in the cache key, thus the old cache was reused without actually installing5.12.0
into the CI environment.Pre-commit.ci uses the version from
pre-commit-config
so that was fine.This PR also updates the version for
flake8
to get in sync to our pre-commit config.--
Tbh as more and more tools start to drop
3.7
, I'm not opposed to doing the same. Maybe after the2.16.0
release?Pylint could still be used to lint
3.7
code, only run with Python3.8
.Failing test from #1992: https://github.com/PyCQA/astroid/actions/runs/4046304756/jobs/6958923838