Fix wrong inference cache result for typing.cast
calls inside functions
#1981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The result for the
typing.cast
inference tip depend could depend on the arguments passed to the parent function.Those aren't included in the cache key which could cause the first (invalid) inference result to be returned again.
This PR adds a new parameter to
inference_tip
->cached
, to be able to opt out of caching for specific inference tips.In most cases this shouldn't be needed. Therefore the default is set to
True
.https://github.com/PyCQA/astroid/blob/dfd88f5edc636df80c8cabd61a6b8d6bc8746ca9/astroid/inference_tip.py#L36-L38
Closes pylint-dev/pylint#8074