Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new plugin for random excuses. #155

Merged
merged 6 commits into from
Oct 6, 2022
Merged

Added new plugin for random excuses. #155

merged 6 commits into from
Oct 6, 2022

Conversation

rakeshseal0
Copy link
Contributor

@rakeshseal0 rakeshseal0 commented Oct 6, 2022 •
edited
Loading

Description

Returns a random excuse for you.

How Has This Been Tested?

Created local devenv and tested manually.

Additional context

Add any other context or screenshots about the pull request here.

Checklist

  • I have read, understood and followed our Contributing Guide
  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I added my country flag to the README.md

Code of Conduct

By submitting this issue, you agree to follow our Code of Conduct

  • I agree to follow this project's Code of Conduct

@rakeshseal0
Copy link
Contributor Author

Added new plugin which returns random excuses.

@rakeshseal0
Copy link
Contributor Author

@MrTanoshii can you check this one?

MrTanoshii
MrTanoshii requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@MrTanoshii MrTanoshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in info.py

@MrTanoshii MrTanoshii added the plugin Related to honeybot plugins label Oct 6, 2022
@MrTanoshii MrTanoshii added the enhancement New feature or request label Oct 6, 2022
@MrTanoshii
Copy link
Member

Note: We broke the black GitHub action check.

Can you please run black <filename> on the files you've added in #151 and #155 (you can do both here)

https://github.com/psf/black#readme

What it does is ensure that we are using the same coding style.
I apologize, I was being lazy and was going to do it myself after merging your PRs but it's better for you to do it

@MrTanoshii MrTanoshii mentioned this pull request Oct 6, 2022
Merged
5 tasks
@MrTanoshii MrTanoshii merged commit a4f4bac into pyhoneybot:master Oct 6, 2022
@rakeshseal0
Copy link
Contributor Author

Thank you @MrTanoshii for being such a nice reviewer.

@rakeshseal0 rakeshseal0 deleted the random-excuse-plugin branch October 6, 2022 10:19
@MrTanoshii
Copy link
Member

No worries, thank you for the contributions.

Have a great day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrTanoshii MrTanoshii MrTanoshii approved these changes

Assignees

@rakeshseal0 rakeshseal0

Labels
enhancement New feature or request hacktoberfest-approved plugin Related to honeybot plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakeshseal0 @MrTanoshii